[syslinux] I heard the patch window was open? Two small patches
Phil Pokorny
ppokorny at penguincomputing.com
Thu Nov 1 17:31:17 PDT 2018
I see that there seems to be patches being accepted...
Please consider committing these two:
You should be able to cherry pick them from my syslinux repo at
http://github.com/ppokorny/syslinux I would think?
commit 64fb71b87a625d70ea8c6127f18fe96d3f4fdc89
Author: Philip Pokorny <ppokorny at penguincomputing.com>
Date: Sun Mar 5 21:07:48 2017 -0800
Fix PATH parsing to match the documentation at
http://www.syslinux.org/wiki/index.php?title=Config#PATH
that the list is space-separated
diff --git a/com32/elflink/ldlinux/readconfig.c
b/com32/elflink/ldlinux/readconfig.c
index 3d6aa27..c6b86d4 100644
--- a/com32/elflink/ldlinux/readconfig.c
+++ b/com32/elflink/ldlinux/readconfig.c
@@ -786,7 +786,7 @@ static int parse_path(char *p)
char *c = p;
/* Find the next directory */
- while (*c && *c != ':')
+ while (*c && !my_isspace(*c))
c++;
str = refstrndup(p, c - p);
commit 647e30a1d12ec8a71551910e06e1d16fca27851e
Author: Philip Pokorny <ppokorny at penguincomputing.com>
Date: Sun Mar 5 20:59:05 2017 -0800
Change path_add so that it adds new entries at the end not
the beginning of the list. This fixes an issue where PATH
with multiple directories listed would effectively reverse
the order of the searched directories
diff --git a/core/path.c b/core/path.c
index 8e517ca..7b4d886 100644
--- a/core/path.c
+++ b/core/path.c
@@ -32,7 +32,7 @@ __export struct path_entry *path_add(const char *str)
if (!entry->str)
goto bail;
- list_add(&entry->list, &PATH);
+ list_add_tail(&entry->list, &PATH);
return entry;
--
Philip Pokorny, RHCE
Chief Technology Officer
PENGUIN COMPUTING, Inc
www.penguincomputing.com
Changing the world through technical innovation
More information about the Syslinux
mailing list