[syslinux] syslinux-6.04-pre2

[Joakim Tjernlund]

On Thu, 2019-02-07 at 13:11 -0800, H. Peter Anvin wrote:
> On 2/6/19 12:07 PM, Joakim Tjernlund wrote:
> > On Wed, 2019-02-06 at 11:56 -0800, H. Peter Anvin wrote:
> > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> > > 
> > > 
> > > On 2/6/19 11:44 AM, Joakim Tjernlund wrote:
> > > > On Wed, 2019-02-06 at 11:34 -0800, H. Peter Anvin wrote:
> > > > 
> > > > Great, that tree now against a somewhat old gnu-efi though.
> > > > 
> > > > To build against >= 3.0.8 I need to do:
> > > >         #gnu-efi >= 3.0.8 has memset/memcpy defined causing multiple syms errors
> > > >       sed -i 's/LDFLAGS =/LDFLAGS = -z muldefs /' mk/efi.mk || die "sed muldefs failed"
> > > > 
> > > 
> > > Should be a trivial fix by simply omitting those from the
> > > syslinux-provided library functions on EFI.
> > 
> > Yes, but I don't know the code that well so I took the easy way :)
> > 
> > Also, syslinux overides/omits xFLAGS(CFLAGS, LDFLAGS etc.) so one cannot
> > pass own flags. Would be nice if one could disable Warnings that are harmless. 
> > 
> 
> Should be easy enough with some changes to the *.mk files which are
> fortunately enough relatively centralized now.

Best should be to use SYSLINUX_CFLAGS for mandatory flags and possibly
set CFLAGS to some sane defaults. CFLAGS must be last on the CC line though.